search

SlRvb / Obsidian--ITS-Theme

Theme designed with readability and customizability in mind. Change it easily to your liking with the Style Settings plugin installed.
https://publish.obsidian.md/slrvb-docs/ITS+Theme/ITS+Theme
GNU General Public License v2.0
545 stars 116 forks source link

Checkboxes in admonitions don't render #64

Closed VeroVerro closed 2 years ago

VeroVerro commented 2 years ago

Hi, thanks for this wonderful theme again :) I'm having a bit of a problem with checkboxes in admonitions though - they render in default theme, but not in ITS theme:

image

image

It's the same whether I use the theme as is without any snippets or style settings, or whether I use admonition and / or checkboxes snippets.

They render fine in reading mode, the previous screenshots are from live preview in editing.

SlRvb commented 2 years ago

I think I've pushed a fix for that here: 1a73d42. Do let me know if it works after updating the theme🙂

VeroVerro commented 2 years ago

Thanks! :)

It mostly works :D The alternate checkboxes work, but an empty one (- [ ] test) doesn't, and for the regular x, only uppercase shows up (so - [X] test is good, - [x] test is not).

SlRvb commented 2 years ago

Can you update one more time? I believe I should have fixed that 🤔

VeroVerro commented 2 years ago

You're right, it's working now :) This one was on me, turns out the problem was in the S - Checkboxes snippet. Once I disabled it, it worked on the empty and x styles too. And I found out I don't need that snippet because the alternate checkboxes are also directly in your theme >.>

Thank you again and sorry for the confusion :)

SlRvb commented 2 years ago

Ah, that's great to hear! Glad it's working now. 🥳