SlRvb / Obsidian--ITS-Theme

Theme designed with readability and customizability in mind. Change it easily to your liking with the Style Settings plugin installed.
https://publish.obsidian.md/slrvb-docs/ITS+Theme/ITS+Theme
GNU General Public License v2.0
545 stars 116 forks source link

First emoji not showing correctly in Reading mode for headers #68

Closed stecydube closed 2 years ago

stecydube commented 2 years ago

Using theme (either regular or nord)

If you use a level 1 header like the following:

# 🍟 header

The emoji icon gets squished.

image

Go deeper for the heading level (like 5 or 6) and it disappears completely.

image

Also, spacing around it is not right when surrounded by spaces in some occasions:

Header πŸ”miam ➑️ pizza

gives

image


Using Obsidian V0.13.23 ITS Theme, latest as of today but the problem existed before On Windows 10

SlRvb commented 2 years ago

This looks like you've got an emoji plugin installed πŸ€”

stecydube commented 2 years ago

Dang, you're right it was caused by the Emoji Toolbar plugin. No longer present when I disabled it.

I'll let them know of the problem. Thank you 😎

stecydube commented 2 years ago

Additional findings. There is clearly a combined effect between a specific style setting and the Emoji Toolbar plugin.

Editing mode

image

Reading mode

ITS theme: default

image

ITS theme with only setting the "Center heading with lines" enabled:

image

image

Works ok for the "Center headings" option though.

image

image

I just noticed that when "Center headings" is active, the underline does not get centered and that's even with the Emoji plugin disabled.

SlRvb commented 2 years ago

Hmm very strange πŸ€” I'll see what's going on.

SlRvb commented 2 years ago

Ahh ok, I see the problem with the emoji toolbar, should be fixed now. f7a5643


As far as the regular center heading line not centering, that was intentional, but I guess I can see if I can also center those lines πŸ€”

Edit: Centered the lines now πŸ‘πŸ½ b57fbf3

stecydube commented 2 years ago

All fixed. Found out that emoji don't show in back ticks when used inside a JS code block when the Emoji plugin is active. Not sure it's on your side though.

For example:

```js
console.log (`πŸͺ`);
SlRvb commented 2 years ago

I think that's an issue with the emoji toolbar πŸ€” Seems to work fine on my vault that doesn't have the plugin installed

stecydube commented 2 years ago

It definitely is an issue with the emoji toolbar, tried it with the default theme. Going to raise an issue with their team.