SlRvb / Obsidian--ITS-Theme

Theme designed with readability and customizability in mind. Change it easily to your liking with the Style Settings plugin installed.
https://publish.obsidian.md/slrvb-docs/ITS+Theme/ITS+Theme
GNU General Public License v2.0
545 stars 116 forks source link

[FR] - Better table handling #70

Closed spiritualgeek closed 2 years ago

spiritualgeek commented 2 years ago

I'd be very appreciative if you'd consider exposing the following to the Style settings plugin:

Dataview tables should work in the same fashion and this should be consistent between reading view and live preview modes (i.e., look exactly the same)

Thanks for a wonderful theme

SlRvb commented 2 years ago

A maximum size that any column can be

I'm a bit unsure what this would be, do you want css classes to resize specific columns or general style settings options to just have columns span the whole note?


Options to minimize (or completely remove) padding

For td and th separately?

spiritualgeek commented 2 years ago

Maybe my explanation is really horrid :)

I hope that this makes more sense?

SlRvb commented 2 years ago

Ah yep, that clears it up perfectly, thanks! I'll see what I can do 🙂

spiritualgeek commented 2 years ago

I keep on coming back to your theme. Thank you for the immense effort you put in to keep these theme fresh and to solve little issues

SlRvb commented 2 years ago

font size for font size for Options to minimize (or completely remove) padding

So I've managed to do these three: 5baba8c3748d84524da7e5457610c875b81719d8. Should find the sliders under Note Elements > Tables.


I'm a bit unsure as of right now how to get max width to work in tables. Not even fully sure max width works in table cells at least in the way you'd want it to work 😔

spiritualgeek commented 2 years ago

It seems to work a treat :) I can't seem to find the font sizing though?

This was fast. Thank you so much

SlRvb commented 2 years ago

Oops, forgot to commit those changes 🤦‍♀️

I've rearranged some stuff and made the settings a little more visually distinct. Also actually added the td and th changes 😅 e0c12b1

Obsidian_ZaGELXPi29

spiritualgeek commented 2 years ago

This works perfectly. Thanks so much!

Just 1 last request. It would be great if it carried across the note text weight.

Or perhaps even had its own :)

Thank you so much. This is outstanding. Highly appreciative.

SlRvb commented 2 years ago

Just 1 last request. It would be great if it carried across the note text weight.

What do you mean? 🤔

spiritualgeek commented 2 years ago

If one changes the note text weight to be a bit heavier it has no impact on the text in the table which it should. Otherwise, a separate font-weight just for tables would be good :)

SlRvb commented 2 years ago

Oooh, interesting. I hadn't noticed that, will fix for both 👍🏽

spiritualgeek commented 2 years ago

.poke :)

SlRvb commented 2 years ago

Oops, so I think I've added support for that here under the Note Elements > Tables 8f3d8e2bb51684c420405ab29d02a1d24881e5e5

spiritualgeek commented 2 years ago

How did I miss that? :) Awesome!