SlRvb / Obsidian--ITS-Theme

Theme designed with readability and customizability in mind. Change it easily to your liking with the Style Settings plugin installed.
https://publish.obsidian.md/slrvb-docs/ITS+Theme/ITS+Theme
GNU General Public License v2.0
531 stars 112 forks source link

[Bug] Kanban extension does not render properly with ITS Theme #99

Closed jasal82 closed 2 years ago

jasal82 commented 2 years ago

Describe the bug

Kanban extension does not render properly. Tags are currently configured as inline-block with text align centered which does not work well with long tags spanning multiple lines in the Kanban cards. They also have a dark background color which shouldn't be the case. The tag markers on the bottom of the cards use .text-dl for the foreground color which is not overridden in the theme.

To Reproduce

Screenshots

image

OS

Where does the bug occur?

Obsidian Version: 0.14.2

SlRvb commented 2 years ago

Is the issue that the bottom tag is basically illegible because of the colors and that tag text is centered? Would you want a toggle to left align tags?

jasal82 commented 2 years ago

Yes exactly. A toggle to left align tags would be great to fix the upper tag. And I'm not sure where that dark background color of the upper tag is coming from since it's rendering without background color outside of the Kanban board. Also I'd like to know if something can be done about the display of the a.tag because I'd rather have it begin in the line that says 'create tasks' and then wrap to the next line. The computed display style says block and cannot be changed in the developer tools. I don't know what is happening there but I guess that's a problem of Kanban itself because it happens with other themes as well.

jasal82 commented 2 years ago

This is what I get with the default theme

image

jasal82 commented 2 years ago

After giving the wrapping issue some more thought I'm pretty sure that it's because of the hyphen which serves as line break indicator and the slashes don't. So that's probably a more general problem and nothing to be fixed in the theme.

SlRvb commented 2 years ago

And I'm not sure where that dark background color of the upper tag is coming from since it's rendering without background color outside of the Kanban board.

This is the default styling for tags in preview mode, but I can add options to have it display as just colored text.

Also I'd like to know if something can be done about the display of the a.tag because I'd rather have it begin in the line that says 'create tasks' and then wrap to the next line. The computed display style says block and cannot be changed in the developer tools. I don't know what is happening there but I guess that's a problem of Kanban itself because it happens with other themes as well.

I can try to see if I can do something with this and get it to work inline 🤔

SlRvb commented 2 years ago

I've added the toggle for simple looking tags under Note Elements > Tags > Colored Text Tags and you can change the text position to align left using the Note Elements > Tags > Tag Text Alignment dropdown. 191c765

But yeah, tags seem to be added to a separate div on the kanban entirely, so I don't think it's possible to have it inline unfortunately 😔

SlRvb commented 2 years ago

If this isn't fixed, do feel free to reopen this issue.