Advancement checks in functions are triggering null advancements in chat

Slabserver / Slabserver-Bugs

Issue tracker for Slabserver infrastructure bugs

0 stars 0 forks source link

Advancement checks in functions are triggering null advancements in chat #22

Closed DaMarine closed 3 years ago

DaMarine commented 4 years ago

N.B: ensure the fix for this does not regress in 1.16 with the advancement name changes

DaMarine commented 4 years ago

Experienced again in 1.16 after getting Ender Evolution, and then killing the Shulker with a new account that got Monster Hunter for the first time.

chrissamael commented 4 years ago

I'm planning to rewrite the advancement handling to a) actively ignore recipes and b) scan Datapacks for advancements and auto-add them on loadup, should fix this issue for good

DaMarine commented 3 years ago

Testing GitHub integration

chrissamael commented 3 years ago

The issue as such has been fixed by adding all advancements to the advancement map inside the plugin. As long as this list keeps getting updated with every added advancement we should be fine.