Erroneous leave messages and delayed/double joins/leaves

DidsheMa commented 3 years ago

Players entering the Bungee network but not entering the Paper server will in some cases (version mismatch, banned player) trigger an unintentional ingame leave message upon leaving the network.

This should be an easy fix, just have the Bouncer keep track of who actually joined the server and not just the network.

Due to the nature of Plugin Messaging System, join/leave messages are now kept in memory and get dispensed in bulk if a world goes back online, and people joined/left the other while it was off. Noticeable during RW resets and server restarts. We also get a few double messages upon the latter - honestly not sure why.

There's two solutions to this:

Short term: Add a timestamp to join/leave messages forwarded to the Paper gatekeeper plugin from the Bouncer, have the gatekeeper check for "decay" and only pass on relevant msgs
Long term: Ditch PMS, and implement a simple SQL-based producer-consumer infrastructure for the join/leave message task within Bouncer and Gatekeeper. This would also allow us to circumvent the stupid requirement of needing at least one player to be online on the main world to be able to forward joins/leaves to Discord.

chrissamael commented 3 years ago

The "short term" solution is already present in the gatekeeper, it's being used for the advancement and death message forwarding from RW to main (and vice versa, for ingame display).

chrissamael commented 3 years ago

Short term solution is currently live, working better overall but there still seem to be fringe (and sadly unreproduceable as of now) cases where leave announcements go missing - Didy and I noticed it happen three times yesterday, in a matter of hours to three different players.

DidsheMa commented 3 years ago

Removed the fix for 1 again as it seems to be what ate up a leave message every now and then for reasons I can't fathom We'll also address this with the long term solution, which should hopefully get rid of all remaining inconsistencies resulting from PMS including the >0 players limit

DidsheMa commented 3 years ago

Long term solution now implemented and tested in Bouncer/GK which should resolve this issue with all its components for good; pending deployment on Slab

DaMarine commented 3 years ago

Whole month without issues, 10/10 would leave/join/doublejoin the server again

Slabserver / Slabserver-Bugs

Erroneous leave messages and delayed/double joins/leaves #33