Slamdunk / phpstan-extensions

Extensions for PHPStan
MIT License
66 stars 13 forks source link

False Positive StringToClassRule #23

Open keywan-ghadami-oxid opened 4 years ago

keywan-ghadami-oxid commented 4 years ago

StringToClassRule reports fails positive for a string containing "Error" in my application.

Maybe this rule is not that important anymore because phpstan can report using string where class-string is expected.

A good compromise to reduce chance of fail positives would be to check only for full qualified class names in strings.

Slamdunk commented 4 years ago

Any PR is welcome :+1: