Slamdunk / phpstan-laminas-framework

Laminas Framework 3 extensions for PHPStan
MIT License
16 stars 10 forks source link

Support Interop and PSR containers for $container->get() resolution #28

Closed InvisibleSmiley closed 2 years ago

InvisibleSmiley commented 2 years ago
InvisibleSmiley commented 2 years ago

This is for issue 27. No idea how to link it.

codecov-commenter commented 2 years ago

Codecov Report

Merging #28 (996c93d) into master (f5c0da2) will decrease coverage by 0.53%. The diff coverage is 40.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #28      +/-   ##
============================================
- Coverage     46.37%   45.83%   -0.54%     
- Complexity       99      105       +6     
============================================
  Files            20       20              
  Lines           248      264      +16     
============================================
+ Hits            115      121       +6     
- Misses          133      143      +10     
Impacted Files Coverage Δ
...AbstractPluginMethodDynamicReturnTypeExtension.php 0.00% <0.00%> (ø)
...as/ServiceManagerGetDynamicReturnTypeExtension.php 0.00% <0.00%> (ø)
.../Rules/Laminas/ServiceManagerGetMethodCallRule.php 95.74% <88.88%> (-1.76%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f5c0da2...996c93d. Read the comment docs.

Slamdunk commented 2 years ago

Awesome contribution, thank you, I'll take care of the CS failed build :+1:

Slamdunk commented 2 years ago

Thank you