search

Slamdunk / phpstan-laminas-framework

Laminas Framework 3 extensions for PHPStan
MIT License
16 stars 10 forks source link

Allow older php versions - since phpstan does allow it too #33

Closed nusphere closed 2 years ago

nusphere commented 2 years ago

see #34

Slamdunk commented 2 years ago

Hi, thank you for the PR but I do not intend to support PHP < 8.0.

nusphere commented 2 years ago

actually php 7.4 is not EOL. And we use PHPStan to upgrade our projects to newer versions.

but there is no possible version to use PHPStan 1.7 with your extension.

@see https://www.php.net/supported-versions.php

Slamdunk commented 2 years ago

I know: my spare time is limited, and I chose to support only the versions of PHP that ease my maintenance burden.

This library is MIT licensed though: feel free to fork it and shape it as you need

nusphere commented 2 years ago

I can understand very well not to support any versions under php 8.0, but especially with phpstan it makes sense to support at least the current version. With the current setting it is not possible to install a current version of PHPStan. Since version 1.6 of PHPStan, the PSR-11 container has also been broken by BetterReflection, so from now on you will be dependent on your extension.

However, when maintaining a PHP 7.4 project, it is now impossible to use your extension, which is quite sad.

The only solution would be - to develop your own extension, which is not a good solution - since you have already done the work.