Slamdunk / phpstan-laminas-framework

Laminas Framework 3 extensions for PHPStan
MIT License
16 stars 10 forks source link

Support container interfaces for get() return type #39

Closed InvisibleSmiley closed 1 year ago

Slamdunk commented 1 year ago

I see that the build is not passing, can you have a look at it please?

InvisibleSmiley commented 1 year ago

The reported errors do not seem to be caused by the changes I made; some of them might even be temporary problems that might go away when re-running the checks (which I do not have the permissions to trigger I think). The codesniffer changes are probably caused by the fact that the rules were changed meanwhile.

I'm pretty sure current master will fail the same. Not sure what your policy is who should fix those issues. In our libraries we use a composer.lock so dependencies (especially dev ones like codesniffer rules) cannot change without explicit action.

I would assume that a PR like mine that is targeted at fixing a certain issue should only do that.

So, how shall we proceed?

Slamdunk commented 1 year ago

Can you rebase this please?

codecov-commenter commented 1 year ago

Codecov Report

Base: 44.00% // Head: 43.16% // Decreases project coverage by -0.83% :warning:

Coverage data is based on head (8038545) compared to base (5b1eabe). Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #39 +/- ## ============================================ - Coverage 44.00% 43.16% -0.84% - Complexity 107 109 +2 ============================================ Files 20 23 +3 Lines 275 278 +3 ============================================ - Hits 121 120 -1 - Misses 154 158 +4 ``` | [Impacted Files](https://codecov.io/gh/Slamdunk/phpstan-laminas-framework/pull/39?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Filippo+Tessarotto) | Coverage Δ | | |---|---|---| | [...actServiceLocatorGetDynamicReturnTypeExtension.php](https://codecov.io/gh/Slamdunk/phpstan-laminas-framework/pull/39/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Filippo+Tessarotto#diff-c3JjL1R5cGUvTGFtaW5hcy9BYnN0cmFjdFNlcnZpY2VMb2NhdG9yR2V0RHluYW1pY1JldHVyblR5cGVFeHRlbnNpb24ucGhw) | `0.00% <0.00%> (ø)` | | | [.../InteropContainerGetDynamicReturnTypeExtension.php](https://codecov.io/gh/Slamdunk/phpstan-laminas-framework/pull/39/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Filippo+Tessarotto#diff-c3JjL1R5cGUvTGFtaW5hcy9JbnRlcm9wQ29udGFpbmVyR2V0RHluYW1pY1JldHVyblR5cGVFeHRlbnNpb24ucGhw) | `0.00% <0.00%> (ø)` | | | [...inas/PsrContainerGetDynamicReturnTypeExtension.php](https://codecov.io/gh/Slamdunk/phpstan-laminas-framework/pull/39/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Filippo+Tessarotto#diff-c3JjL1R5cGUvTGFtaW5hcy9Qc3JDb250YWluZXJHZXREeW5hbWljUmV0dXJuVHlwZUV4dGVuc2lvbi5waHA=) | `0.00% <0.00%> (ø)` | | | [...as/ServiceManagerGetDynamicReturnTypeExtension.php](https://codecov.io/gh/Slamdunk/phpstan-laminas-framework/pull/39/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Filippo+Tessarotto#diff-c3JjL1R5cGUvTGFtaW5hcy9TZXJ2aWNlTWFuYWdlckdldER5bmFtaWNSZXR1cm5UeXBlRXh0ZW5zaW9uLnBocA==) | `0.00% <ø> (ø)` | | | [src/UnmappedAliasServiceLocatorProxy.php](https://codecov.io/gh/Slamdunk/phpstan-laminas-framework/pull/39/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Filippo+Tessarotto#diff-c3JjL1VubWFwcGVkQWxpYXNTZXJ2aWNlTG9jYXRvclByb3h5LnBocA==) | `45.45% <ø> (ø)` | | | [src/Type/Laminas/PluginMethodReflection.php](https://codecov.io/gh/Slamdunk/phpstan-laminas-framework/pull/39/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Filippo+Tessarotto#diff-c3JjL1R5cGUvTGFtaW5hcy9QbHVnaW5NZXRob2RSZWZsZWN0aW9uLnBocA==) | `100.00% <0.00%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Filippo+Tessarotto). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Filippo+Tessarotto)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

InvisibleSmiley commented 1 year ago

Rebased and "fixed" the coding standard issues. Not sure what to do about the rest (Codecov) though.