Closed InvisibleSmiley closed 1 year ago
The reported errors do not seem to be caused by the changes I made; some of them might even be temporary problems that might go away when re-running the checks (which I do not have the permissions to trigger I think). The codesniffer changes are probably caused by the fact that the rules were changed meanwhile.
I'm pretty sure current master will fail the same. Not sure what your policy is who should fix those issues. In our libraries we use a composer.lock so dependencies (especially dev ones like codesniffer rules) cannot change without explicit action.
I would assume that a PR like mine that is targeted at fixing a certain issue should only do that.
So, how shall we proceed?
Can you rebase this please?
Base: 44.00% // Head: 43.16% // Decreases project coverage by -0.83%
:warning:
Coverage data is based on head (
8038545
) compared to base (5b1eabe
). Patch coverage: 0.00% of modified lines in pull request are covered.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
Rebased and "fixed" the coding standard issues. Not sure what to do about the rest (Codecov) though.
I see that the build is not passing, can you have a look at it please?