Slamtec / rplidar_ros

BSD 2-Clause "Simplified" License
504 stars 532 forks source link

fixed out of range indexing for angle_compensate #15

Open Philippe-Capdepuy opened 5 years ago

Philippe-Capdepuy commented 5 years ago

Hi, We encoutered issues on A3 with angle_compensate active in Sensitivity mode (and other non 360 array sizes). Basically the indexing goes out of range, causing some random crashes on Raspberry Pi for instance, especially when LIDAR has all points valid (non 0). It worked fine on x86 architectures, but still goes out of range and may cause some random bugs. The patch simply skips points that are out of the array. I tried to make sense of the angle_compensate calculations, but I'm not sure what it's exactly supposed to do, also it seems pretty inefficient, overwriting the same array cells multiple times.