Closed Nesh108 closed 7 years ago
Hey nesh! That's really good! But if you do a quick git pull, you would realize that requirements.txt problem is already fixed, and yes that linux readme is good! But maybe I am missing something why did you put all of those modules in gitignore?
Ohh man. I must have forked it yesterday and then didn't check anymore. My bad!
About the gitignore, it's because after running python3 install.py
, files get compiled and, since they are not ignored, they are shown as changes, which clearly nobody should push :)
Here is the list of changes after installing the required libraries:
Stephanie/AudioManager/__pycache__/__init__.cpython-35.pyc
Stephanie/AudioManager/__pycache__/audio_getter.cpython-35.pyc
Stephanie/AudioManager/__pycache__/audio_manager.cpython-35.pyc
Stephanie/AudioManager/__pycache__/audio_recognizer.cpython-35.pyc
Stephanie/EventDispatcher/__pycache__/__init__.cpython-35.pyc
Stephanie/EventDispatcher/__pycache__/event_dispatcher.cpython-35.pyc
Stephanie/TextManager/__pycache__/__init__.cpython-35.pyc
Stephanie/TextManager/__pycache__/speaker.cpython-35.pyc
Stephanie/TextManager/__pycache__/text_manager.cpython-35.pyc
Stephanie/TextManager/__pycache__/text_recognizer.cpython-35.pyc
Stephanie/TextProcessor/__pycache__/__init__.cpython-35.pyc
Stephanie/TextProcessor/__pycache__/audio_text_manager.cpython-35.pyc
Stephanie/TextProcessor/__pycache__/module_router.cpython-35.pyc
Stephanie/TextProcessor/__pycache__/text_learner.cpython-35.pyc
Stephanie/TextProcessor/__pycache__/text_processor.cpython-35.pyc
Stephanie/TextProcessor/__pycache__/text_sorter.cpython-35.pyc
Stephanie/__pycache__/__init__.cpython-35.pyc
Stephanie/__pycache__/activity.cpython-35.pyc
Stephanie/__pycache__/boot.cpython-35.pyc
Stephanie/__pycache__/commander.cpython-35.pyc
Stephanie/__pycache__/configurer.cpython-35.pyc
Stephanie/__pycache__/updater.cpython-35.pyc
Stephanie/__pycache__/virtual_assistant.cpython-35.pyc
Stephanie/local_libs/__pycache__/__init__.cpython-35.pyc
Stephanie/local_libs/__pycache__/activity_search.cpython-35.pyc
The gitignore hides all those :)
Oh Yes!! I didn't notice there was no .gitignore! but maybe this will be better one? How about you change that .gitignore to this one? and remove requirements.txt and readme.md is good, send me a request of that and I will gladly merge it. :D
# Created by .ignore support plugin (hsz.mobi)
### Python template
# Byte-compiled / optimized / DLL files
__pycache__/
*.py[cod]
*$py.class
# C extensions
*.so
# Distribution / packaging
.Python
env/
build/
develop-eggs/
dist/
downloads/
eggs/
.eggs/
lib/
lib64/
parts/
sdist/
var/
wheels/
*.egg-info/
.installed.cfg
*.egg
# PyInstaller
# Usually these files are written by a python script from a template
# before PyInstaller builds the exe, so as to inject date/other infos into it.
*.manifest
*.spec
# Installer logs
pip-log.txt
pip-delete-this-directory.txt
# Unit test / coverage reports
htmlcov/
.tox/
.coverage
.coverage.*
.cache
nosetests.xml
coverage.xml
*,cover
.hypothesis/
# Translations
*.mo
*.pot
# Django stuff:
*.log
local_settings.py
# Flask stuff:
instance/
.webassets-cache
# Scrapy stuff:
.scrapy
# Sphinx documentation
docs/_build/
# PyBuilder
target/
# Jupyter Notebook
.ipynb_checkpoints
# pyenv
.python-version
# celery beat schedule file
celerybeat-schedule
# SageMath parsed files
*.sage.py
# dotenv
.env
# virtualenv
.venv
venv/
ENV/
# Spyder project settings
.spyderproject
# Rope project settings
.ropeproject
# Pycharm IDE
.idea
.gitignore
Ok done! By the way, the requirements.txt
is exactly the same, so it's not a problem :)
Heya, I just started by installing Stephanie, so I had to fix stuff as I am on Linux (Ubuntu) and I thought I would contributing.
I added .gitignore for ignoring files after installation, updated the readme file and fixed the
requirements.txt
as dateutil is actually calledpython-dateutil
and thewebbrowser
is built-in.If you would like some additional help, let me know if you need something specific. Otherwise I thought of making some sort of visual interface and improving usability here and there :)