search

SlapBot / stephanie-va

Stephanie is an open-source platform built specifically for voice-controlled applications as well as to automate daily tasks imitating much of an virtual assistant's work.
https://slapbot.github.io/
MIT License
799 stars 127 forks source link

Fixed sound player and exception #13

Closed Nesh108 closed 7 years ago

Nesh108 commented 7 years ago

Hey!

Again I forgot to check your speedy fix of the sound issue but I thought using platform would help in readability, so I kept it in :)

I noticed that you were not checking the tts_option when playing the beep sound, so I fixed that. On my system (Linux), playing the sound through pygame is way better than using the os (it opens the default audio player which is just plain ugly).

I think there should be a manager for this kind of things but for now, since we are checking the tts_option just twice, it doesn't matter. I also cleaned up a bit the exceptions for readability.

SlapBot commented 7 years ago

Hey nesh! Thanks for contributing again, but build isn't working as of now, there are some issues with beepstart.mp3 alongside you can't put # comments in config.ini file, don't worry though, I have cloned your fork, and let me send a pull request to that after which you send a request here, that I'll merge, Cheers.

SlapBot commented 7 years ago

And I believe guys at pygame have fixed that bug, so should we make mixer our default voice commander?

Nesh108 commented 7 years ago

Yeah, let's do that!