SlashDevin / NeoGPS

NMEA and ublox GPS parser for Arduino, configurable to use as few as 10 bytes of RAM
GNU General Public License v3.0
702 stars 195 forks source link

Doesn't build when using ESP32 core 2.0.4 with Arduino #161

Open av4625 opened 2 years ago

av4625 commented 2 years ago

I have been using this library "fine" (there are a ton of compiler warnings) with 2.0.2 but there is a bug for SD cards in 2.0.2 meaning I updated to 2.0.4.

Now on 2.0.4 a lot of these compiler warnings are treated as errors and it no longer builds.

Errors are below, there are some other warnings as well that I have not shown.

Arduino/libraries/NeoGPS/src/ublox/ubxNMEA.cpp: In member function 'virtual bool ubloxNMEA::parseField(char)':
Arduino/libraries/NeoGPS/src/ublox/ubxNMEA.cpp:36:9: error: case value '10' not in enumerated type 'NMEAGPS::nmea_msg_t' [-Werror=switch]
         case PUBX_04: return parsePUBX_04( chr );
Arduino/libraries/NeoGPS/src/ublox/ubxGPS.cpp: In member function 'bool ubloxGPS::parseNavPvt(uint8_t)':
Arduino/libraries/NeoGPS/src/ublox/ubxGPS.cpp:629:8: error: unused variable 'ok' [-Werror=unused-variable]
   bool ok = true;
        ^~
Arduino/libraries/NeoGPS/src/ublox/ubxGPS.cpp:919:1: error: no return statement in function returning non-void [-Werror=return-type]
 } // parseNavPvt
 ^
Arduino/libraries/NeoGPS/src/ublox/ubxGPS.cpp: At global scope:
Arduino/libraries/NeoGPS/src/ublox/ubxGPS.cpp:118:13: error: 'char toHexDigit(uint8_t)' defined but not used [-Werror=unused-function]
 static char toHexDigit( uint8_t val )
             ^~~~~~~~~~
cc1plus: some warnings being treated as errors
cc1plus: some warnings being treated as errors