SlashNephy / Divination.AetheryteLinkInChat

Repository Moved -> https://github.com/SlashNephy/Divination
MIT License
7 stars 3 forks source link

world cannot always be correctly identified #18

Open LittleNightmare opened 1 year ago

LittleNightmare commented 1 year ago

if a message contain multiple world's names, it will only output one.

in CN servers, this issue is more serious. there are some world's name same as map name. For example, YanXia is not only a map name, but also a world name in CN server. if there is a flag mark on 'YanXia', plugin told me first change world, and then go to Namai

https://github.com/horoscope-dev/Divination.AetheryteLinkInChat/blob/062e7882d2bbcfeb5a845fd94f3ce9a50fcdf048/Divination.AetheryteLinkInChat/AetheryteSolver.cs#L111

SlashNephy commented 1 year ago

Thank you for your report.

I'm sorry for the lack of testing on the Chinese version. I will add a setting to display the world name as an opt-in feature.

Originally, it was a simple implementation to extract the world name from chat messages, so it would misfunction if the same word as the world name was included. If SE would include World in MapPayload, it would solve the problem...