SlashNephy / Divination

FINAL FANTASY XIV toolkits
http://xiv.starry.blue/
MIT License
15 stars 7 forks source link

[AetheryteLinkInChat] Some aetherites do not contribute to distance calculations #656

Open SlashNephy opened 2 months ago

SlashNephy commented 2 months ago

Which plugin are you referring to? AetheryteLinkInChat

Describe the bug

Some aetherites do not contribute to the distance calculation, so in reality, a more distant route is presented as the shortest route.

e.g. Yanxia (12, 30) for rank S Gamma We should teleport to Doman Enclave but AetheryteLinkInChat suggests Namai village.

Rueby commented 1 month ago

I'd like to add another example aetheryte that I encountered, I hope this is helpful?

Map - North Thanalan S Rank : Minhocao (20.7, 27.8) - This location is closer to the Camp Bluefog Aetheryte [South Aetheryte].

I got teleported to the Ceruleum Processing Plant [North Aetheryte] which is the further route.

Happens also on (22.3, 27.1) which is closer to the south aetheryte.

Edit: I realized I could just take screenshots of it

image Closest is Yedlihmad (I believe or at least there's less of flying up and out thats in the great works)

Diyagi commented 2 days ago

Most of issues i had with this was due to the fact that we only have an 2d coords, which means height is not accounted in the calculations, theres the fact that the calculation is not an path finder, its just an straight line from the aetherites to the flag ignoring walls, terrain, etc The only solution i could come up with was to add negative weight to some aetherites to account for that, while this will work well for places like Tertium - Garlemald, it might not work well on others.