search

Slashbunny / gog-galaxy-plugin-downloader

Downloads and Updates GOG Galaxy 2.0 Plugins/Integrations
GNU General Public License v3.0
268 stars 20 forks source link

Can't install via scoop #14

Closed katsanva closed 4 years ago

katsanva commented 4 years ago

It seems wrong naming issue - it searches for gog-plugins-downloader-stores.exe but probably should for gog-plugins-downloader.exe


PS C:\Users\thisi> scoop install gog-galaxy-plugin-downloader
>>
Installing 'gog-galaxy-plugin-downloader' (0.2.2) [64bit]
gog-plugins-downloader-v0.2.2.zip (6,0 MB) [==================================================================] 100%
Checking hash of gog-plugins-downloader-v0.2.2.zip ... ok.
Extracting gog-plugins-downloader-v0.2.2.zip ... done.
Linking ~\scoop\apps\gog-galaxy-plugin-downloader\current => ~\scoop\apps\gog-galaxy-plugin-downloader\0.2.2
Creating shim for 'gog-plugins-downloader-stores'.
Can't shim 'gog-plugins-downloader-stores.exe': File doesn't exist.```
Slashbunny commented 4 years ago

@JanPokorny will probably need to correct this in the scoop package, since it's unaffiliated with this project. I removed the 3 separate executables a while ago.

I'm guessing this needs to change? https://github.com/lukesampson/scoop-extras/blob/master/bucket/gog-galaxy-plugin-downloader.json

JanPokorny commented 4 years ago

@Slashbunny Hi, I'm sorry but I'm without a computer for a few days, writing this from my phone.

However if you wish to make the fix yourself, it's pretty easy. Just make a PR to change the "bin" field in the json file you linked to the correct executables, and also the "notes" field to reflect updated usage. (Or just delete the "notes" field, a GitHub link is shown anyway.) You can probably manage to do all that from the GitHub web editor, it's just pain to use on phone.

Slashbunny commented 4 years ago

It looks like this was reported in the scoop-extras project and fixed in https://github.com/lukesampson/scoop-extras/issues/3420