Unknown variable: 'phpfpm::params::manage_package'

Slashbunny / puppet-phpfpm

Manages php-fpm daemon and pool configuration

GNU General Public License v3.0

10 stars 29 forks source link

Unknown variable: 'phpfpm::params::manage_package' #29

Closed dhoppe closed 5 years ago

dhoppe commented 5 years ago

If the following line is a default, it should be defined outside the case condition.

https://github.com/Slashbunny/puppet-phpfpm/blob/master/manifests/params.pp#L13

CentOS 7 for example provides the package php-fpm, but it is not installed by this module because the parameter manage_package is missing.

Slashbunny commented 5 years ago

Thanks for the report, I completely missed this in the MR that introduced the manage_package variable. I agree historically it's been true by default (prior to the variable existing) and now it's basically only true for Debian, which is a regression. I'll hopefully fix this on the weekend.