Closed chriscauley closed 1 year ago
@chriscauley the close button on the sidebar isn't working
@chriscauley also as you click between cells there seems to be a flash of the sidebar rendering in the bottom-left before getting positioned along the right edge. Is that a style-level issue we should leave for Ryon or something to do with the rendering lifecycle?
Noting that @ryon isn't able to jump back in ATM. For right now we are going to move ahead with the functionality and circle back with the CSS at a later time.
Updates:
FABULOUS
@chriscauley one regression I just found in this PR that doesn't appear to have been introduced by Ryon's work is that the portfolio progress bar is hardcoded to 50
In this screenshot, the current develop
branch is on the left and this PR is on the right, same student+competency (ELA, Class of 2020)
I have upgraded the code base from vue2 to vue3 and replaced vue-bootstrap with the latest version of beautify. The big remaining question is how much you want me to try to make it match the existing designs. I thought that was more Ryon's domain and am afraid I'll get in the way.
Changes