SlateFoundation / slate-cbl

http://slatefoundation.github.io/slate-cbl/
MIT License
7 stars 7 forks source link

fix: show previous portfolios for enrollment #786

Closed BillClinton closed 1 year ago

BillClinton commented 1 year ago

Currently the Portfolio Manage sidebar does not show any levels below the lowest level with a portfolio. This means users cannot enroll in those levels. This fix will change the behavior of the application, showing all levels, and enabling enrollment in those levels.

One note: a computed property "visibleLevels" exists in the AdvancedPortfolioSidebar component. This property returns an array of the levels with portfolios. Now that we are showing all levels in the sidebar, this property is no longer used in this component, but it is passed down to and used in subcomponents:

While the function of this property is the same, technically since we are now showing all levels, it might be better named levelsWithPortfolios or enrolledLevels something similar. @themightychris Let me know if you think a change like this would be warranted.