Don't generate line 0 in profdata_coverage_file.rb from line with error

SlatherOrg / slather

Generate test coverage reports for Xcode projects & hook it into CI.

MIT License

1.56k stars 238 forks source link

Don't generate line 0 in profdata_coverage_file.rb from line with error #449

Closed tthbalazs closed 4 years ago

tthbalazs commented 4 years ago

There is already a PR open since May 2018 for this problem: https://github.com/SlatherOrg/slather/pull/387

The issue is still valid when passing the XML to sonar-scanner.

I changed a few minor things compared to the original PR and I also included some test cases. I had troubles running all tests locally, hopefully this meets the coverage expectations.

coveralls commented 4 years ago

Coverage decreased (-0.01%) to 95.708% when pulling 395a25e271511eebd6ab2da46c758335a4ba26b8 on tthbalazs:ignore-error-lines into e3e628b877eb34b0008c374b4b97898fe4b952d3 on SlatherOrg:master.

ksuther commented 4 years ago

Thanks for the PR!