SlatherOrg / slather

Generate test coverage reports for Xcode projects & hook it into CI.
MIT License
1.55k stars 236 forks source link

fix #561: Set a default true return value for when source_files is empty. #563

Closed jarrodlombardo-EventBase closed 3 months ago

jarrodlombardo-EventBase commented 3 months ago

coverage_info.include_files? needs a default true return value for when source_files is empty.

jarrodlombardo-EventBase commented 3 months ago

@dnedrow @ksuther This fixes #561 afaict.

ksuther commented 3 months ago

I'm happy to make a release if someone can confirm it works for them.

jarrodlombardo-EventBase commented 3 months ago

@gaige can you try this?

gaige commented 3 months ago

I’ll look at it in a couple of hours. I don’t have access to my systems until I get home.

gaige commented 3 months ago

@gaige can you try this?

@jarrodlombardo-EventBase Managed to do it on my phone :-)

Looks good. All 8 runs I tried appear to have consistent output with prior version!

ksuther commented 3 months ago

Thanks for the fix and thanks for checking! I'll make a new release soon.