SlavikMIPT / tgcloud

Opensource Telegram based cloud storage
https://dev.tgcloud.xyz
Apache License 2.0
558 stars 83 forks source link

Python 3 compatibility issues #15

Open cclauss opened 5 years ago

cclauss commented 5 years ago

Python 2 end of life is in less than 200 days...

flake8 testing of https://github.com/SlavikMIPT/tgcloud on Python 3.7.1

$ flake8 . --count --select=E9,F63,F72,F82 --show-source --statistics

./dedupfs/get_memory_usage.py:42:13: E999 SyntaxError: invalid syntax
    print msg % (format_size(counter), format_size(new_memory_usage), format_size(difference), format_size(deviation))
            ^
./dedupfs/fuse.py:59:34: E999 SyntaxError: invalid syntax
                           (var, `pattern`))
                                 ^
./dedupfs/dedupfs.py:49:19: E999 SyntaxError: invalid syntax
except ImportError, e:
                  ^
3     E999 SyntaxError: invalid syntax
3

E901,E999,F821,F822,F823 are the "showstopper" flake8 issues that can halt the runtime with a SyntaxError, NameError, etc. These 5 are different from most other flake8 issues which are merely "style violations" -- useful for readability but they do not effect runtime safety.

Is your feature request related to a problem? Please describe. A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

Describe the solution you'd like A clear and concise description of what you want to happen.

Describe alternatives you've considered A clear and concise description of any alternative solutions or features you've considered.

Additional context Add any other context or screenshots about the feature request here.

VadVergasov commented 5 years ago

Run this threw python2, as it showed on https://habr.com/en/company/vds/blog/456290/ you need to run

python3.6 download_service.py

with python 3, but

python dedupfs/dedupfs.py --block-size 10240000 storage/

with python 2. Also, download_service.py have the first line, which shows that it is python3, but dedupfs have python 2. Hope it helped.