Slazanger / SMT

Slazanger's Eve Map Tool
MIT License
264 stars 77 forks source link

Fail quietly ESI calls where HTTP 400s are an acceptable code outcome #116

Closed tehraven closed 1 year ago

tehraven commented 1 year ago

Some ESI calls are coded to allow for the ESI to return 400-level errors, but were not surrounded with a try-catch to guard against (mostly) HTTP issues connecting to ESI.

I've simply wrapped them in do-nothing try-catches.

Worth noting that although this pattern exists already in the file, technically we should do something like log or display this error to users so they can be informed that SMT is not functioning as they might expect.