Slazanger / SMT

Slazanger's Eve Map Tool
MIT License
264 stars 77 forks source link

Fixing off-by-one error in Jump Bridge Clipboard import. #31

Closed mminnick closed 4 years ago

mminnick commented 4 years ago

Fixes #30

I was curious when you closed that issue as I thought I'd tried that. When I dug a bit deeper, I saw you had an off-by-one error in the clipboard import for jump bridges. I fixed this error on my fork, and when I copied in the format you specified, the jump bridges were added from the clipboard just as you said they'd be. (Bonus is that I was able to copy that JumpBridges.dat to the current stable version too).

mminnick commented 4 years ago

Ah I see. I think this is going to be a problem with ESI. The explanation of the esi-search.search-structures.v1 scope is not accurate. It claims to search structures you can see in the structure browser, but it only returns structures you have docking access to.

For instance, there's a jumpgate from RQOO-U to LXQ2-T that I use daily in-game, that shows up in the structure browser in-game. But when I search structures (with the right scope in the Swagger UI) with the string LXQ2-T, it returns only the stations in LXQ2-T and does not return the jumpgate either from or to RQOO-U. I assume this is because I cannot "dock" at the Ansiblex, only use it (That or the structure is private. I don't know, I've never anchored an Upwell structure before).

I know you're using the structure ID for putting waypoints in-game. If you can replicate this I will put in a bug report to CCP.

Slazanger commented 4 years ago

This is a long standing esi bug : https://github.com/esi/esi-issues/issues/108

mminnick commented 4 years ago

Oh boyyyyyyyyy. Gotta love those. Thanks. :)