search

Slazanger / SMT

Slazanger's Eve Map Tool
MIT License
264 stars 77 forks source link

Max Intel Lines #63

Closed Raykazi closed 2 years ago

Paic commented 3 years ago

I like the idea of setting a max number of line for the intel collection, it prevent it from getting too big and laggy.

What about directly removing the last item in the ObservableCollection in IntelDataList_CollectionChanged if a new one is added ? I think that would avoid some mental gymnastic with a flag being set and used in a background thread. Would it be to costly in performance ?

Slazanger commented 3 years ago

I think limiting by time is more useful.. like the zkb feed

Paic commented 3 years ago

When you're saying by time you mean like "keep only the intel that is less than 2 hours old" ? Indeed if it is that it is better to do it the way the PR is already coded, that would limit the number of time the collection has to be iterated.

Slazanger commented 3 years ago

basically yes, although I was thinking a default that matched the zkill feed

Slazanger commented 2 years ago

This ended up implemented as part of an additional optimisation