search

SleepWalker / hoauth

yii-hoauth provides simple integration with social network authorisation lib Hybridauth in Yii.
Other
59 stars 35 forks source link

please add to packagist/composer #45

Open cornernote opened 10 years ago

cornernote commented 10 years ago

This will allow simple installation outside of my application's path. Let me know if you need a sample composer.json and I will do a pull request.

SleepWalker commented 10 years ago

Hi, @cornernote so I simply need to commit something like this:

{
    "name": "sleepwalker/hoauth",
}

and than simply add my project to packagist, am I right?

P.S. I don't want to add hybridauth as dependency now. I will make a huge update, when I finally will be ready with my university and than I'll use the latest version of hybridauth, witch is very active maintained at the moment!

cornernote commented 10 years ago

Yep, that should do it. You need to remove the comma otherwise it's not valid json.

SleepWalker commented 10 years ago

oh, yes. sorry) I have added the version number there before I have read that it is not required and after that introduced this mistake)

SleepWalker commented 10 years ago

I have added it. But packagist says that you need use "sleepwalker/hoauth": "dev-master" instead of "sleepwalker/hoauth": "1.2.4". Is it normal, or packagist sees no tags in my repo?

RdeWilde commented 10 years ago

You should add the dependency, you should lock it to a specific tag/release. When you update your code, you could update the dependent version too. https://github.com/hybridauth/hybridauth

Packagist should index all versions. Be sure to enable the update hook, see packagist profile page for details

RdeWilde commented 10 years ago

Maybe consider creating a seperate branch, as you should not directly include the hybridauth source into your own source. It would be managed through composer dependency.

RdeWilde commented 10 years ago

I understand it'll be a breaking change, but you could consider integrating into composer autoloading as Yii is also committing to the PSR* conventions which are also used by composer for generating the autoloader.

SleepWalker commented 10 years ago

HybridAuth I will make as dependency later, because at the moment in my repo the modificated version of old HybridAuth. And the new one version I should test, before I can write it as a dependency, so I will do that later, when I will have a little more time. It's okay so?

RdeWilde commented 10 years ago

I understand. Will fork.

You can actually fork the hybridauth repository to your own user. Add your changes to it (overwrite). Commit and push to your own fork. Include the original hybridauth as a dependency, but meanwhile add to your composer.json

"repositories" : [

        {
            "type": "git",
            "url": "https://github.com/hybridauth/hybridauth.git"
        }
]

This will overrule the dependency resolution to your own fork. You can control what version will be used in updates.

Side-effect is that your fork is actually mergeable with the original (both ways).