search

Sleeper85 / esphome-jk-bms-can

GNU General Public License v3.0
64 stars 18 forks source link

Slider Charging current max #6

Closed oseldusan closed 5 months ago

oseldusan commented 6 months ago

Hi Sleeper85. Could you please correct row No. 1005 in your yaml , where is max value for slider Charging current max right now 150A? I suggest to use max_value: "${charge_a}" . Thank you very much.

Sleeper85 commented 6 months ago

Hi oseldusan, If we define it with the value of ${charge_a} then we cannot increase it via the slider. I don't know if this is a good idea, would that mean that ${charge_a} is the max value?

OselDusan7 commented 6 months ago

Thats correct. So what about bigger value ? 200A ? 300A ? 2x${charge_a}, ${charge_a} +50A , new value which can be set at "user area" at begining ? I know , I can change it by myself in code , but after few days ( weeks ) I have no idea what I did in the past :o) , and I will replace it with your new code.

Sleeper85 commented 6 months ago

Ok, using ${charge_a} +50A seems like a good idea. I will add this in the next version.

Sleeper85 commented 5 months ago

Adapted in V1.16.1.