search

Sleepwalking / ciglet

Lightweight signal processing library for audio and speech applications
62 stars 18 forks source link

formula error #1

Closed tuxzz closed 7 years ago

tuxzz commented 7 years ago
  1. ciglet.c#L1338: E0 shoule be -model.Ee / (exp_3(ret.a ret.Te) ret.sin_wgTe)
  2. ciglet.c#L1405: y[i] should be *- Ee / e / Ta (exp_2(- e (t - Te)) - exp_2(- e (T0 - Te))); Formula in [1] p.8 has a typo. Read [2] p.18** instead.

[1] Fant, Gunnar, Johan Liljencrants, and Qi-guang Lin. "A four-parameter model of glottal flow." STL-QPSR 4.1985 (1985): 1-13. [2] Doval, Boris, Christophe d'Alessandro, and Nathalie Henrich. "The spectrum of glottal flow models." Acta acustica united with acustica 92.6 (2006):

Sleepwalking commented 7 years ago

Thank you for reporting the typos. I was able to confirm the bracketing mistake and that the caption in [1] Fig. 2 is indeed a typo, though [1] eq. 11 is correct. The typos are fixed in commit cd8f73af57cfffc35c781c135ce618df1e64dd76.