search

SleepyTrousers / EnderCore

Library mod used by EnderIO, EnderZoo, and others
Creative Commons Zero v1.0 Universal
50 stars 71 forks source link

Use static logger to avoid classloading other classes. #45

Closed gabizou closed 8 years ago

gabizou commented 8 years ago

This is an updated PR compared to #37 for 1.9's development. This will prevent other forge/mc classes from being loaded far too early for other transformers to apply their transformations, namely SpongeForge.

I've tested this build locally and in production in both a client and server environment with no breakages.

LuxusDarkangel commented 8 years ago

Poking @tterrag1098, can this be merged, please? It's very annoying not being able to use EnderIO with Sponge.

LuxusDarkangel commented 8 years ago

@HenryLoenwind? @CrazyPants? Can you please throw some light at this and why it's not being merged?

CrazyPants commented 8 years ago

This will be in build EnderCore-0.4.0.25 and up (building now) Could you please test this and confirm it is working as expected?

gabizou commented 8 years ago

Yep, works perfectly. :) Many thanks!

Aaron1011 commented 8 years ago

@CrazyPants: If you're still maintaining the 1.8.9 version, could you please merge https://github.com/SleepyTrousers/EnderCore/pull/37? It's the original version of this PR, targeted for 1.8.9.

tterrag1098 commented 8 years ago

We are not maintaining 1.8.X anymore