SleepyTrousers / EnderIO-1.5-1.12

http://enderio.com/
The Unlicense
729 stars 359 forks source link

Enchantments disabled but still usable on gear? #5312

Closed Yourname942 closed 4 years ago

Yourname942 commented 4 years ago

Issue Description:

The enchantments from EnderIO are able to enchant gear and apply their effects, even after being disabled in the config.

What happens:

1) I'm able to enchant my gear with witherarrow and witherweapon, even when disabled in config. 2) the witherarrow enchantment is able to applied to a sword and causes wither to mobs

What you expected to happen:

1) l expected the enchantments that I disabled to be disabled.. ( B:enabled=false ), but they are still available to use and apply their effects to gear. 2) I expected wither enchantment for ranged weapons to only be applied to ranged weapons and not on a sword

Steps to reproduce:

  1. create a new world: a) cheats enabled b) superflat
  2. press E and get an anvil, a diamond sword, wither sword enchantment, and wither arrow enchantment
  3. place an anvil down
  4. insert diamond sword into anvil
  5. combine with wither sword
  6. attack a mob (they get withered)
  7. press E and get a new diamond sword
  8. insert the new/ different diamond sword into anvil
  9. combine with wither arrow
  10. attack a mob (they get withered) ...

Affected Versions (Do not use "latest"):

Your most recent log file where the issue was present:

latest.log

CitiesXL2815 commented 4 years ago

EnderIO has two enchants that wither for bows and Decay for swords but there other mods can override EnderIO Enchants like quark for example so sometimes configs don't work as they are supposed too

tyler489 commented 4 years ago

I believe that wither arrow is an endercore enchant not enderio although I could be wrong.

HenryLoenwind commented 4 years ago

Please test in survival mode. Creative mode skips most of the enchanting checks.