search

SleipnirGroup / Choreo

A graphical tool for planning time-optimized trajectories for autonomous mobile robots in the FIRST Robotics Competition.
BSD 3-Clause "New" or "Revised" License
150 stars 46 forks source link

C++ `AutoFactory` constructor documentation refers to non-existent `Choreo::CreateAutoFactory()` #905

Closed bhall-ctre closed 2 weeks ago

bhall-ctre commented 3 weeks ago

The documentation for the AutoFactory constructor only points to a Choreo::CreateAutoFactory() function, which exists in Java but not C++.

It looks like the class comment is also out-of-date with recent changes to Choreo (such as AutoLoop -> AutoRoutine).

calcmogul commented 3 weeks ago

Turns out those files don't even get compiled, and the Java tests that would have caught that were never ported to C++ (C++ has almost no tests). We clearly have some process improvements to do.