Sleitnick / AeroGameFramework

AeroGameFramework is a Roblox game framework that makes development easy and fun. The framework is designed to simplify the communication between modules and seamlessly bridge the gap between the server and client.
https://sleitnick.github.io/AeroGameFramework/
MIT License
215 stars 57 forks source link

Upgrade to Promise v3.0.1 #197

Closed evaera closed 4 years ago

evaera commented 4 years ago

https://github.com/evaera/roblox-lua-promise/security/advisories/GHSA-mq7h-vf5c-52f4

Impact

Promise.delay's internal thread scheduler has a bug in v3.0.0 that can cause Promise.delay to error which can interrupt the Promise chain with errors escaping the Promise library.

Promise.is would return false for Promises created with roblox-lua-promise@v2 which would break some APIs when passing Promises to things like Promise.all.

Patches

Upgrade to version v3.0.1 which fixes these issues.

Workarounds

There are no good ways to work around these issues.