Sleitnick / AeroGameFramework

AeroGameFramework is a Roblox game framework that makes development easy and fun. The framework is designed to simplify the communication between modules and seamlessly bridge the gap between the server and client.
https://sleitnick.github.io/AeroGameFramework/
MIT License
216 stars 57 forks source link

Data module should use Promises #80

Closed Sleitnick closed 5 years ago

Sleitnick commented 5 years ago

The new Data module (in the data branch) should return Promises for values that can fail. Currently, it returns a tuple. But this also means that the default behavior is to yield for data requests, which is not ideal. Yielding systems like this should be asynchronous, and thus using Promises would be a great fit.

This also means including a Promise implementation into the framework as a Shared module. There's a good implementation by LPHhatguy for Roblox.

Sleitnick commented 5 years ago

Done