Sleitnick / rbxcloud

CLI and library for Roblox Open Cloud API
https://sleitnick.github.io/rbxcloud/
MIT License
101 stars 11 forks source link

Place publishing 409 error message lacking #38

Closed Sleitnick closed 11 months ago

Sleitnick commented 11 months ago

Roblox's documentation states that a 409 HTTP error for place-publishing should contain the following message: " Place not part of the universe." However, this error also occurs if the place is open in team create (see #37).

Currently, rbxcloud hard-codes the error message to the same message that Roblox has documented. However, this message is misleading in the case of the aforementioned team create scenario.

Relevant code: https://github.com/Sleitnick/rbxcloud/blob/main/src/rbx/experience.rs#L91

Questions:

If Roblox's HTTP response already contains a proper error message, that error message should be used instead of hard-coding a new message.

Sleitnick commented 11 months ago

This might also be relevant to other status codes, not just the 409.