SlenkyDev / StopRussia.net.ua

Based on https://stop-russian-desinformation.near.page
The Unlicense
42 stars 14 forks source link

rubaltic: avoid redirect and bypass application cache #18

Closed timespace42 closed 2 years ago

timespace42 commented 2 years ago

Hi there, please also add the new patern into the root index.html file. Also, I'd like to please ask you to build the website using the guide in README.md before submiting a pull-request.

Thank you!

Will do for now, however building PR and keeping /dist under version control makes no sense. Is it something you can re-configure @SlenkyDev ?

SlenkyDev commented 2 years ago

Hi there, please also add the new patern into the root index.html file. Also, I'd like to please ask you to build the website using the guide in README.md before submiting a pull-request. Thank you!

Will do for now, however building PR and keeping /dist under version control makes no sense. Is it something you can re-configure @SlenkyDev ?

I wasn't the one who originally made it that way as I didn't make the frontend, @OLIMINATOR did. I'll let him know.

timespace42 commented 2 years ago

@SlenkyDev @OLIMINATOR here is what changed since review:

  1. Prettier fixed and now applies automatically on local env, most of the changes are automatic formatting
  2. Changed flood results refresh to happen 2 times per second
  3. Removed statics from index.html
SlenkyDev commented 2 years ago

Should be good 👍