SlexAxton / css-colorguard

Keep a watchful eye on your css colors.
2.44k stars 65 forks source link

Error and Warning output #28

Closed XOP closed 9 years ago

XOP commented 9 years ago

I'm experiencing strange output, something like

Running "colorguard:files" (colorguard) task
Warning: undefined:708:90: property missing ':' Use --force to continue.

Aborted due to warnings.

Even if I target single file, it's impossible to detect typo in this fragment.

I suggest either fixing or providing more clear output.

SlexAxton commented 9 years ago

Is this issue valid still @XOP ? Or did you close it for some reason?

Thanks!

XOP commented 9 years ago

Hi @SlexAxton! This is valid, however I suggested it refers to the grunt-colorguard plugin, so I moved question there. If you have any thoughts, it would be nice if you share. I'm thinking about some specific rules like

::-webkit-input-placeholder {color: #999;}

can cause the error, but anyway the task shouldn't just drop out.

SlexAxton commented 9 years ago

Ah. This is a problem with reworkcss. It was more or less abandoned and lots of these edge cases never made their way in.

We pushed a 1.x version of colorguard yesterday that moves it over to PostCSS, which means it can handle this. You just need grunt-colorguard to update their dependency (which includes a few small API integration changes).

XOP commented 9 years ago

That certainly makes sense!

Thanks, I'll pass this to grunt-colorguard developers.