search

SlexAxton / css-colorguard

Keep a watchful eye on your css colors.
2.44k stars 65 forks source link

Add color identifying properties to PostCSS warning #35

Closed davidtheclark closed 8 years ago

davidtheclark commented 8 years ago

This is following up on an issue in stylelint, https://github.com/stylelint/stylelint/pull/888.

stylelint (and anything like stylelint, that uses this module in a kind of atypical way) would be better off with the violating colors accessible directly on the warning object, instead of having to parse the warning text message in order to get them. This PR adds that functionality.

What do you think?

ben-eb commented 8 years ago

LGTM, aside from code style. :+1:

Can you fix up and squash the commits please?

SlexAxton commented 8 years ago

:+1:

davidtheclark commented 8 years ago

Instead of just fixing that missing semicolon I thought I'd add jshint to the test process so that the build will fail next time. Think that's reasonable?

ben-eb commented 8 years ago

That works for me. :+1:

Should we squash the commits together?

davidtheclark commented 8 years ago

Squashed.

ben-eb commented 8 years ago

Thanks David. :tada:

ben-eb commented 8 years ago

Released as 1.1.0.