search

Slicejack / bojler

Bojler is an email framework
https://bojler.slicejack.com
MIT License
1.03k stars 59 forks source link

Regexp to seek if and endifs comments #120

Closed luigimannoni closed 5 years ago

luigimannoni commented 5 years ago

Fixes #119

Drops processConditionalComments since it only supports proper HTML fragments (self open and closed fragments in the same comment) and adds a very basic ignoreCustomComments regexp.

Now boilerplate-with-hero.html correctly compiles with the closing VML tags and strips out all the other comments (although the whitespace is left there).

alenvuletic commented 5 years ago

Hi @luigimannoni, you have tested this one on a real project?

Thanks for your contribution!

luigimannoni commented 5 years ago

Yep, I am using this variation for an e-mail we are building in house. Successfully tested with Litmus.

alenvuletic commented 5 years ago

I'll release this under v4.1.1.