search

Slicejack / bojler

Bojler is an email framework
https://bojler.slicejack.com
MIT License
1.03k stars 59 forks source link

Adds natives module needed to run on Mac OS X #121

Closed luigimannoni closed 5 years ago

luigimannoni commented 5 years ago

Doesn't run on MacOS Node v10.16.0 unless we install this module, might need a bit of testing if it doesn't interfere with other OSes (but I don't think it will).

luigimannoni commented 5 years ago

Curiously also node on Windows requires this package

alenvuletic commented 5 years ago

Hi @luigimannoni, you have tested this one on a real project?

Thanks for your contribution!

luigimannoni commented 5 years ago

@alenvuletic same comment as in #120 : we're building some emails in house across MacOS and Windows both Node.js 10.16.0 (LTS) - both needed this devDependency.

I haven't got access to a Linux machine to test with it now so would be good if you can input your feedback on this if you have a Linux machine.

On a side note Bojler doesn't work on Node.js 12 on Mac but that might be another completely separate issue.

alenvuletic commented 5 years ago

Great, if you're able to make fix for Node.js 12 please create another pull request and we can discuss, thanks for helping out!

Also any other suggestions and contributions are welcomed!

alenvuletic commented 5 years ago

I'll release this under v4.1.1.