Slicer / SlicerLanguagePacks

3D Slicer extension for creating, editing, and storing translations for Slicer core and extensions
MIT License
7 stars 11 forks source link

Mark translatable strings in Markups module #37

Open idrissa10 opened 10 months ago

idrissa10 commented 10 months ago
idrissa10 commented 10 months ago

https://github.com/idrissa10/Slicer/commit/90fd711b10e0f7a75505eeef5fb9561e3ac6c558

lassoan commented 10 months ago

Thank you, I had a quick look at the referenced commit and it seemed all right. Please submit a pull request when it's ready for review.

lassoan commented 3 months ago

After making markup type translatable, make sure these extensions can be build with both the old and new version of the Markups node:

#define TRANSLATABLE_MARKUP_TYPE 1 could be added to vtkMRMLMarkupsNode.h and then in the extension you can add

#ifdef TRANSLATABLE_MARKUP_TYPE 
...
#else
...
#endif

to specify code that works with the old/new version.