search

Slicer / SlicerOpenCV

Slicer Extension wrapping OpenCV
Other
12 stars 10 forks source link

OpenCV wrappings in python #12

Closed fedorov closed 6 years ago

naucoin commented 8 years ago

Pull request gets the python wrapping enabled for all platforms, but the ctest on Windows is disabled as it's not finding the wrapped package when run from the command line, but it does run from the self tests GUI when the extension is installed.

fedorov commented 8 years ago

I think that as long as it doesn't break any existing functionality, should be ok to merge. Let's merge and monitor the dashboards?

naucoin commented 8 years ago

With the windows ctest commented out so that we don't lose the dependent extensions, it doesn't break anything, just adds. I'll see if we get to the windows issue on the SlicerDev hangout and either fix or merge afterward.

naucoin commented 8 years ago

JC doesn't have time to look into this until Friday, merging and monitoring now.

naucoin commented 8 years ago

http://na-mic.org/Mantis/view.php?id=4183 is the related issue

fedorov commented 7 years ago

@naucoin there is a startup error on Mac below, can this affect functionality of the C++ OpenCV users, or it is python wrapping specific?

image

naucoin commented 7 years ago

It's python wrapping specific, and only affects the self test.

fedorov commented 7 years ago

Great, thanks!

fedorov commented 6 years ago

Superseded by #46