Slicer / slicer.org

This site is published at slicer.org.
https://slicer.org
Other
0 stars 8 forks source link

Ensure latest version of style is used after slicer.org or download.slicer.org deployement #140

Closed jcfr closed 2 years ago

jcfr commented 2 years ago

Following the integration of https://github.com/Slicer/slicer.org/pull/136, I observed that the website needed a "hard refresh" to properly display the icon.

This is because the style was modified and we don't have "cache busting" mechanism in place.

Proposed solution

See https://murfitt.net/blog/cache-busting-with-jekyll

cc: @jamesobutler @lassoan @pieper

pieper commented 2 years ago

Personally I think this was a small enough issue and rare enough that we don't need to implement a special workaround. We don't really plan on changing this content much.

jamesobutler commented 2 years ago

@jcfr was it "hard refreshed" based on https://github.com/Slicer/slicer.org/commit/02bb08e8ee675da195dec08ab79e02b66b6cb871? It currently doesn't seem to include changes from https://github.com/Slicer/slicer.org/commit/aa6ed1923be914dae5839db73e8966bfd4e85128 as the site currently looks like https://github.com/Slicer/slicer.org/pull/136#issuecomment-1031377116.

jcfr commented 2 years ago

If you look the bottom of the page, it includes the following:

image

This means that the html is the correct one as it based of https://github.com/Slicer/slicer.org/commit/d5fd015

But as you correctly observed the style currently in the cache is the one being used, and this explained what you experienced.