Slicer / slicer.org

This site is published at slicer.org.
https://slicer.org
Other
0 stars 8 forks source link

carousel: Update "1 million downloads milestone" image #150

Closed jcfr closed 1 year ago

jcfr commented 2 years ago

Follow up of 81bd31a (carousel: Add 1 million downloads milestone) to account for change introduced in Slicer/slicer_download_stats@73ec581eb (index: Rename "Slicer4" to "Slicer") through https://github.com/Slicer/slicer_download_stats/pull/2

jcfr commented 2 years ago

use the Slicer 5 logo on the download stats page

Thanks for the review :pray:

This makes sense. I will update the download stat site and then follow up with an update to this pull request.

jamesobutler commented 2 years ago

@jcfr Here's a new image with updated logo. Details the specific day when the page recorded crossing 1 million downloads. It is not exactly the same as the previous in that it includes 5.0 and 5.1 versions. image

jcfr commented 2 years ago

For some reason, the GitHub preview shows the same content before/after. https://github.com/Slicer/slicer.org/pull/150/files#diff-1f4dbcde0c156397332daf09f0cb90f0190d5172ca32cc7a7177c9777092b24a

jamesobutler commented 2 years ago

https://github.com/Slicer/slicer.org/pull/150/files#diff-1f4dbcde0c156397332daf09f0cb90f0190d5172ca32cc7a7177c9777092b24a

It's a game of spot the difference, but I see the change from "Slicer4" to "Slicer". Note that I haven't pushed the new image to this branch. Only posted it as a comment for you to modify your commit.

jcfr commented 2 years ago

Note that I haven't pushed the new image to this branch. Only posted it as a comment for you to modify your commit.

Gotcha. I will get to this later this evening .. now getting in the :car:

jamesobutler commented 2 years ago

@jcfr I've pushed a commit to update the image to include the latest changes regarding title and logo used on the download stats page.

jamesobutler commented 2 years ago

Looks like aspect ratio matters. The import parts of the image got cut off with my latest image.

image