Slicer / slicer.org

This site is published at slicer.org.
https://slicer.org
Other
0 stars 8 forks source link

open SlicerSolutions links in new tab #39

Closed pieper closed 4 years ago

pieper commented 4 years ago

Can we add target="_blank" rel="noopener"? (or whatever is best practice) That should make it more likely that users will continue to explore Slicer after visiting one of the solution sites.

jcfr commented 4 years ago

I suggest we use: https://github.com/keithmifsud/jekyll-target-blank and have all external link automatically open in a new windows.

jcfr commented 4 years ago

@faiza-a Let me know if you have any success using https://github.com/keithmifsud/jekyll-target-blank

Here is what I tried:

diff --git a/Gemfile b/Gemfile
index 97c557e..0683bae 100644
--- a/Gemfile
+++ b/Gemfile
@@ -29,3 +29,5 @@ end
 # Performance-booster for watching directories on Windows
 gem "wdm", "~> 0.1.1", :platforms => [:mingw, :x64_mingw, :mswin]

+# Plugins
+gem 'jekyll-target-blank'
diff --git a/_config.yml b/_config.yml
index b319757..ee8d140 100644
--- a/_config.yml
+++ b/_config.yml
@@ -23,13 +23,14 @@ email: your-email@example.com
 description: >- # this means to ignore newlines until "baseurl:"
   3D Slicer biomedical image computing platform.
 baseurl: "" # the subpath of your site, e.g. /blog
-url: "slicer.org" # the base hostname & protocol for your site, e.g. http://example.com
+url: "https://slicer.org" # the base hostname & protocol for your site, e.g. http://example.com
 logo_image: /assets/img/3D-Slicer-Mark.svg

 # Build settings
 remote_theme: chrisrhymes/bulma-clean-theme
 plugins:
   - jekyll-feed
+  - jekyll-target-blank

 # Exclude from processing.
jcfr commented 4 years ago

@faiza-a To try on your side, the branch with my experiment is 39-landing-page-redesign-open-link-different-window (see diff)