SlicerLatinAmerica / TutorialMaker

1 stars 5 forks source link

Screenshot annotator improvements #14

Open lassoan opened 8 months ago

lassoan commented 8 months ago
DouSam commented 7 months ago

@lassoan I think not only the ratios of the icons but the images too. When the screenshot is taken, its resolution is the Slicer resolution. So, on my computer will take an ultrawide screenshot, and in my notebook a 4k screenshot. I think all the screenshots should be sized to 1080p for example.

vmms commented 7 months ago

@lassoan @LuskasHusty @enriquehdez98 I can the latest version on an iMac computer that was not used for development and found that when taking the screenshot the entire screen is taken into account, not just the Slicer window. For example, if Slicer is not maximized you can see that the desktop is captured in the background. Captura de pantalla 2024-03-18 a la(s) 20 29 31

But if it is maximized you can still see that the Apple taskbar is captured. Captura de pantalla 2024-03-18 a la(s) 20 30 33

This causes problems regarding the position of the widgets, since since they are being stored in the JSON, the relative position is captured with respect to the Slicer window and not to the position of the screen.

Even in the second image where Slicer is maximized, the annotations are out of focus due to the taskbar.

LuskasHusty commented 7 months ago

@vmms That is a issue with the screenshot capture tool then. I'ill look into it, until then please confirm that you are using the latest version.

vmms commented 7 months ago

The versions I used are:

DouSam commented 7 months ago

The versions I used are:

  • Slicer 5.7.0
  • TutorialMaker 31-01-2024 Then, on another Mac with an extended screen the same problem happens, it even combines the two monitors Captura de pantalla 2024-03-19 a la(s) 9 59 24 a m  (2)

@vmms clone the extension again. One of Lucas's last commits has solved this problem!

vmms commented 7 months ago

@lassoan The point: Need to be able to add text to click markers. Arrows have text, but do they need text in all annotations?

lassoan commented 7 months ago

Most of the time arrows will have text, but if we only want to highlight one thing in the image then it is possible that there is no text.

vmms commented 1 month ago

I modified the code so that when there is no text in the input field the box is not painted, but when there is text it is painted along with a box. Captura de pantalla 2024-09-23 a la(s) 2 42 41 p m

DouSam commented 1 month ago

Good. Dont forget to make a commit with these changes. You can create a new branch using the updated version of the repository.

vmms commented 1 month ago

Now when you change the color of the arrow, the color of the accompanying text box also changes. The default color was orange. Also, I increased the limit of characters that can be written, and added a function to make the box larger and fit the text.

Captura de pantalla 2024-09-24 a la(s) 10 52 59 a m