search

SlicerProstate / mpReview

3D Slicer extension for streamlined annotation of images
Other
11 stars 16 forks source link

Improvement of User Experience #114

Closed che85 closed 8 years ago

che85 commented 8 years ago

fixes #73 fixes #104 fixes #106

fedorov commented 8 years ago

@che85 :+1: I tested, and it looks great to me, thanks!

@brikeats let us know if you have any concerns. If I don't hear back from you, I plan to merge this pm.

che85 commented 8 years ago

Added another commit which displays further information for selected study

brikeats commented 8 years ago

It looks good, but the latest commit (bb76e) doesn't work for me. It correctly highlights the study and collapses the study box, but no series are displayed. Here is the log: commit-bb76e-log.txt

The previous commit (b96ed1) looks good and functions correctly as far as I can tell.

che85 commented 8 years ago

@brikeats Can you provide this dataset to me?

che85 commented 8 years ago

@brikeats Can you try it with the most recent commit? A few minutes ago, I committed something.

brikeats commented 8 years ago

@che85 Yes, commit 8a6cb5 works fine. Do you still need the dataset?

che85 commented 8 years ago

@brikeats No, I already found the reason for that. Thanks :)

fedorov commented 8 years ago

@brikeats thank you for testing!

@che85 are you done, is this ready for merging?

che85 commented 8 years ago

@fedorov Yes I would say so. I am currently working on other issues. So I will be creating a new PR then.