search

SlicerRt / SlicerRT

Open-source toolkit for radiation therapy research, an extension of 3D Slicer. Features include DICOM-RT import/export, dose volume histogram, dose accumulation, external beam planning (TPS), structure comparison and morphology, isodose line/surface generation, etc.
https://slicerrt.org
127 stars 60 forks source link

Fix implicit instantiation of std::array for Windows and MacOS build #134

Closed MichaelColonel closed 4 years ago

cpinter commented 4 years ago

Could you please explain in the commit message the reason and purpose of this change?

MichaelColonel commented 4 years ago

There are several errors for Windows and MacOS builds. Linux build doesn't have such problem, since some c++11 headers are included implicitly. I can only test linux distribution at home.

cpinter commented 4 years ago

Then please add this into the commit message, and change the prefix to "COMP:"

MichaelColonel commented 4 years ago

Could you check that commit name is correct now?

cpinter commented 4 years ago

I don't mean to be nitpicking here, but the commit message is very generic. You already described it in greater detail in the previous commit message and then here in a comment. Could you just copy-paste it there? It is not advantageous trying to be as concise as possible in the commit messages, but the opposite! Thank you!

MichaelColonel commented 4 years ago

I have added a more detailed commit message.

cpinter commented 4 years ago

Excellent, thank you very much!