SlicerRt / SlicerRT

Open-source toolkit for radiation therapy research, an extension of 3D Slicer. Features include DICOM-RT import/export, dose volume histogram, dose accumulation, external beam planning (TPS), structure comparison and morphology, isodose line/surface generation, etc.
https://slicerrt.org
126 stars 60 forks source link

BUG: Fix SegmentComparison on transformed segments #163

Closed Sunderlandkyl closed 2 years ago

Sunderlandkyl commented 3 years ago

Parent transforms were not applied to the binary labelmaps before performing comparison.

Re-introduces segment transformation code that was removed in: ee200954c0d4adddf1bda8854382f7d0ae3aea9d

MichaelColonel commented 3 years ago

Tests with latest Slicer 4,13

VTK8 build: 1 - qSlicerBeamsModuleGenericTest (Failed) 2 - qSlicerBeamsModuleWidgetGenericTest (Failed) 47 - py_nomainwindow_PlmProtonDoseEngineTest (Failed)

VTK9 build: 1 - qSlicerBeamsModuleGenericTest (Failed) 2 - qSlicerBeamsModuleWidgetGenericTest (Failed) 6 - vtkSlicerIsodoseModuleLogicTest_EclipseProstate (Failed) 47 - py_nomainwindow_PlmProtonDoseEngineTest (Failed)

In VTK9 build test py_IGRTWorkflow_SelfTest crashed with exception

Register Day 2 CT to Day 1 CT using rigid registration.
  It may take a few minutes...
Traceback (most recent call last):
  File "/home/michel/devel/git/SlicerRT/Slicer-SuperBuild-Release-VTK9/inner-build/lib/Slicer-4.13/qt-scripted-modules/IGRTWorkflow_SelfTest.py", line 407, in TestSection_04_RegisterDay2CTToDay1CT
    self.cliBrainsFitRigidNode = slicer.cli.run(brainsFit, None, parametersRigid)
  File "/home/michel/devel/git/Slicer/Slicer-SuperBuild-Release-VTK9/Slicer-build/bin/Python/slicer/cli.py", line 72, in run
    node = createNode(module, parameters)
  File "/home/michel/devel/git/Slicer/Slicer-SuperBuild-Release-VTK9/Slicer-build/bin/Python/slicer/cli.py", line 13, in createNode
    node = cliLogic.CreateNodeInScene()
AttributeError: 'SlicerBaseLogic.vtkSlicerModuleLogic' object has no attribute 'CreateNodeInScene'
Test caused exception!
'SlicerBaseLogic.vtkSlicerModuleLogic' object has no attribute 'CreateNodeInScene'
ok
runTest (slicer.ScriptedLoadableModule.ScriptedLoadableModuleTest) ... No test is defined in ScriptedLoadableModuleTest
ok