Closed MichaelColonel closed 3 years ago
What happened? You opened this issue, then created a PR, which was not integrated, then you closed this issue. In such a case explanation would be welcome.
Apologies, miss click. There are more than one commit in that branch, so should that branch be deleted or squashed?
Absolutely, squash it please. I don't see a good reason for keeping five commits for one changed line. Thanks!
PR is squashed, let's hope there will be no compilation problems on site.
Could it be possible that factory build and SuperBuild 3DSlicer has different DCMTK versions, because i don't have plastimatch compilation errors because of DCMTK (on my PC)?
UPD: DCMTK version in Plastimatch SuperBuild is 3.6.2, in 3DSlicer's DCMTK version is 3.6.5
Factory compilation have been successful last couple of days, and i think this issue can be closed.
Windows build: http://slicer.cdash.org/buildSummary.php?buildid=2053208 Linux build: http://slicer.cdash.org/buildSummary.php?buildid=2052960
It looks like making a branch from plastimatch master HEAD was a bad idea. There is an error because of some DCMTK item tag.
Solution:
Here is a new branch that should compile: https://gitlab.com/MichaelColonel/plastimatch/-/commits/drr-factory-comp