search

SlicerRt / SlicerRT

Open-source toolkit for radiation therapy research, an extension of 3D Slicer. Features include DICOM-RT import/export, dose volume histogram, dose accumulation, external beam planning (TPS), structure comparison and morphology, isodose line/surface generation, etc.
https://slicerrt.org
126 stars 60 forks source link

3DSlicer factory unable to compile plastimatch because of DRR commit. #164

Closed MichaelColonel closed 3 years ago

MichaelColonel commented 3 years ago

Windows build: http://slicer.cdash.org/buildSummary.php?buildid=2053208 Linux build: http://slicer.cdash.org/buildSummary.php?buildid=2052960

It looks like making a branch from plastimatch master HEAD was a bad idea. There is an error because of some DCMTK item tag.

Solution:

  1. Take previous plastimatch tag which works: 2e729bc2c7c4eaa51184ed0acb23d91e615a7ff8
  2. Add needed DRR elements for SlicerRT

Here is a new branch that should compile: https://gitlab.com/MichaelColonel/plastimatch/-/commits/drr-factory-comp

cpinter commented 3 years ago

What happened? You opened this issue, then created a PR, which was not integrated, then you closed this issue. In such a case explanation would be welcome.

MichaelColonel commented 3 years ago

Apologies, miss click. There are more than one commit in that branch, so should that branch be deleted or squashed?

cpinter commented 3 years ago

Absolutely, squash it please. I don't see a good reason for keeping five commits for one changed line. Thanks!

MichaelColonel commented 3 years ago

PR is squashed, let's hope there will be no compilation problems on site.

Could it be possible that factory build and SuperBuild 3DSlicer has different DCMTK versions, because i don't have plastimatch compilation errors because of DCMTK (on my PC)?

UPD: DCMTK version in Plastimatch SuperBuild is 3.6.2, in 3DSlicer's DCMTK version is 3.6.5

MichaelColonel commented 3 years ago

Factory compilation have been successful last couple of days, and i think this issue can be closed.